Problem with "If" and "ThingCount" (ACS)

[CrusherOverride]

Hey everyone! I'm really new to this site and doom modding in general.

 

In my map I want to made so Cyberdemon and 8 Barons of Hell are fighting on the "ring". When one team dies, the crusher will be activated and will crush everyone else and bridge will raise, so player can continue, but there is a problem: I just can't get the code to work. The first part (when they infight) I already made and it works perfectly, but I cannot get the If statement to work (I also tried While but it does not work either).

 

Maybe it's because of "||" (Logical OR), but I don't know.

 

Here is my code so you can see what I did wrong.

 

[plums]

Right now your script runs once, and if neither the all the cyberdemons nor barons are dead when it runs, just skips that part and finishes and exits the script.

 

What you probably need is a loop in there that just waits for either group to be dead, and then completes the rest of the script.

 

something like this (COMPLETELY UNTESTED, MAYBE THERE ARE OTHER PROBLEMS TOO, YOU NEED TO TRY IT FOR YOURSELF)
 

script 1 (void)
{
    // first part, keep the same

    // second part
    until (ThingCount(T_CYBERDEMON, 11)==0 || ThingCount(T_BARON, 12)==0)
    {
        delay 35;
    }

    Ceiling_CrushRaiseAndStay(9, 32, 10000, 0);
    // other stuff after the crusher
}

 

You could also put the "waiting for a group to die" bit in an OPEN script that will run automatically at the start of the level. In your case probably either works.

Edited April 7 by plums

[Stabbey]

Perhaps add in additional parameters for clarity so each half of the statement is taken as one whole and see if that helps:

 

If ((ThingCount(T_CYBERDEMON, 11) == 0) || (ThingCount(T_BARON, 12) == 0))

[CrusherOverride]

Thanks everyone! Both variants work perfectly!